proposed unified code formatting #10
Open
tomasz-lewicki wants to merge 2 commits intodeepaktalwardt:masterfrom
Open
proposed unified code formatting #10tomasz-lewicki wants to merge 2 commits intodeepaktalwardt:masterfrom
tomasz-lewicki wants to merge 2 commits intodeepaktalwardt:masterfrom
Conversation
tomasz-lewicki
requested review from
Parshwa27,
deepaktalwardt,
greeshmavyas and
leehj825
Collaborator
|
This is a good idea. I agree to stick to one format. I will fix the format as I update each file. |
Owner
|
Yeah, I think this is a good idea. Is everyone okay with Google's format though? I really prefer WebKit format. But I'm okay with whatever you guys prefer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey All,
I don't wanna play any formatting sheriff here, but we are running into some issues (see f7f391e ).
We have 2 space vs 4 space indent mixed, and later they can occur as changes if we edit file using a different editor. How about we stick to one format?
We could, for example use a formatting tool to adhere to one format (google style guide in this case):
This PR is just to show how it would work on one file. Let me know what you think!