feat: add Arize Phoenix tracing integration#904
Closed
MichaelMcCulloch-deepsense-ai wants to merge 16 commits intodevelopfrom
Closed
feat: add Arize Phoenix tracing integration#904MichaelMcCulloch-deepsense-ai wants to merge 16 commits intodevelopfrom
MichaelMcCulloch-deepsense-ai wants to merge 16 commits intodevelopfrom
Conversation
Contributor
|
Code Coverage SummaryDetailsDiff against mainResults for commit: 8bd7d0a Minimum allowed coverage is ♻️ This comment has been updated with latest results |
mkoruszowic
reviewed
Jan 19, 2026
Comment on lines
+76
to
+79
| phoenix = [ | ||
| "arize-phoenix>=4.0.0,<5.0.0", | ||
| "openinference-instrumentation>=0.1.0,<1.0.0", | ||
| ] |
Collaborator
There was a problem hiding this comment.
Why are the range constraints so restrictive? uv uses >=4.36.0 by default
Collaborator
Author
There was a problem hiding this comment.
12.0.0; 0.1.41
Collaborator
There was a problem hiding this comment.
Please update uv.lock accordingly
| # /// script | ||
| # requires-python = ">=3.10" | ||
| # dependencies = [ | ||
| # "ragbits-core[phoenix]", |
Collaborator
There was a problem hiding this comment.
Maybe it will be good to have constraint for the version where this extras will be available
Collaborator
Author
There was a problem hiding this comment.
And which version would that be?
Collaborator
There was a problem hiding this comment.
I think it will be included in the next release which is 1.4.0 . Am I right @mhordynski ?
…le, and conditionally import openinference trace modules in tests.
Co-authored-by: Michal Pstrag <47692610+micpst@users.noreply.github.com>
…le, and conditionally import openinference trace modules in tests.
…le, and conditionally import openinference trace modules in tests.
…te usage for consistency.
Collaborator
Author
|
resolving conflicts brought in a bunch of unrelated files. Should not have rebased. Moving to #912 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.