Now working on Windows 10 latest Chrome #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ww9
changed the title
aslafy-z
suggested changes
Nov 5, 2018
aslafy-z
left a comment
aslafy-z
left a comment
There was a problem hiding this comment.
Get chrome path from registry for Windows
| CHROME_CMD = "chrome.exe" | ||
| USER_DATA_DIR = r"%LOCALAPPDATA%\Google\Chrome\User Data" | ||
| elif sys.platform.startswith("win"): | ||
| CHROME_CMD = "\"C:\\Program Files (x86)\\Google\\Chrome\Application\\chrome.exe\"" |
There was a problem hiding this comment.
I think you should use this kind of discovery method to ensure the path is good:
https://stackoverflow.com/a/44588190
Author
There was a problem hiding this comment.
Completely agree, hardcoded path is bad. However I'm short in time and just wanted to get it working on my pretty standard Windows 10 installation. There's also the potential problem of having to escalate privileges to fetch this registry. But don't quote me on that one.
This patch also fixes other problems when running on Windows so I was hopping for it to land and be further improved upon by someone else with a bit more time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows 10, Google Chrome 70.0.3538.77
took 2 minutes to make it work with my rusty python ¯\_(ツ)_/¯