Conversation
|
Ok I don' t understand why tests fails this time, I closed my previous pull request #233 since I don't know enough tape and zuul to be able to contribute + time factor. This time I went very simple : I only change the package.json to require the patched version of tap-finished of @vvo Do you have any idea on what's going on ? |
|
Yes its failing because tests cannot run in a PR (encrypted environment variables for saucelabs tests being not available) This should work but its adding a tarball dep, I would really want to get the PR merged in tap-finished. Also I am no more testing on IE6-7 that's why this is not high priority for me. I would advise you to use a fork of zuul for the time being. Until we make tap-finished PR merged (but I will not spend time on it..) |
Use @vvo patch of tap-finished : see #223