Heeds warning and replaces PResult with ModalResult in parser module#5
Open
sts10 wants to merge 1 commit intodemarque:mainfrom
Open
Heeds warning and replaces PResult with ModalResult in parser module#5sts10 wants to merge 1 commit intodemarque:mainfrom
sts10 wants to merge 1 commit intodemarque:mainfrom
Conversation
Member
|
Hey Sam! Thanks for your contribution and we're super glad you find value in our library. Looking at it, we're a bit behind on the winnow updates and we should fix that. They have a few compatibility changes, and I'll see if we can do the update to the latest version and fix them all. |
Author
|
Makes sense! Feel free to close this PR if tidier that way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
cargo testpopped up some warnings from Winnow. I was able to fix one with a quick find-and-replace. There's still one pertaining to an error type that I couldn't quickly fix.Thank you so much for writing a MARC tool in Rust. Looking forward to using it as I progress through my first MLIS courses.