Improve support for embedded systems like OpenWrt#42
Open
xwang1498 wants to merge 2 commits intodenilsonsa:masterfrom
Open
Improve support for embedded systems like OpenWrt#42xwang1498 wants to merge 2 commits intodenilsonsa:masterfrom
xwang1498 wants to merge 2 commits intodenilsonsa:masterfrom
Conversation
Embedded systems like OpenWrt don't have either stty or tput commands. But we can fall back to using bash itself in interactive mode to discover the terminal size.
Busybox ping prints sequence numbers as `seq=xxx`, rather than `icmp_seq=xxx` like most other ping utilities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenWrt (and perhaps other embedded systems):
sttyortputcommands to discover the terminal size.This PR fixes both, by: not complaining if tput fails, falling back to bash itself to discover the terminal size, and supporting Busybox ping's output format.