Ending the delay and starting the execution at the same update#182
Open
skalogryz wants to merge 2 commits intodentedpixel:masterfrom
Open
Ending the delay and starting the execution at the same update#182skalogryz wants to merge 2 commits intodentedpixel:masterfrom
skalogryz wants to merge 2 commits intodentedpixel:masterfrom
Conversation
… This allows to retain deltatime in passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delta Time applied to the delay is eventually lost (in the next frame) and is never applied to "passed" time of a tween.
This could cause some issues, where the time sequencing is important. (i.e. the final step of the sequence destroys the object, thus it's necessary that all previous steps are completed).
Thus the "loss" of any amount of time needs to be avoided.
Currently the delay and "start" of a tween always occur in separate frames.
The patch changes this behavior, by reducing the delay first, and IF the delay becomes negative "starts" the tween.
It's still possible to split running out of the delay and starting the tween into different frames, and maintain the delta time difference, but just requires adding some extra flags to the tween, and I did want to avoid that for the sake of simplicity.