Skip to content

fix start networking.service before network is marked online #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tjjh89017 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix start networking.service before network is marked online #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...otfs/stretch/common/overlay/etc/systemd/system/networking.service.d/switchdev-online.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
[Unit]
After=network-pre.target
After=local-fs.target network-pre.target
Copy link
Contributor

@paulmenzel paulmenzel Apr 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of local-fs.target maybe use sysinit.target (bootup(7)), and remove the DefaultDependencies=no?

Before=shutdown.target network.target network-online.target
Copy link
Contributor

@paulmenzel paulmenzel Apr 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add to the commit message, that ifupdown is doing the same:

Requires=ifupdown-pre.service
Wants=network.target
After=local-fs.target network-pre.target apparmor.service systemd-sysctl.service systemd-modules-load.service ifupdown-pre.service
Before=network.target shutdown.target network-online.target
Conflicts=shutdown.target

Copy link
Author

@tjjh89017 tjjh89017 Apr 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I just tried to follow ifupdown's config to setup this.
Thanks
I will add those commit message next time!