This repository was archived by the owner on Jan 18, 2020. It is now read-only.
Open
Conversation
Owner
|
Thanks, I'll have a look at it. Let me take some time for that. |
Owner
There was a problem hiding this comment.
Do we really need 'unblock' in the last line?
return $ CipherCtx ctx
Owner
|
I reviewed your patch and found some changes that don't look identical to the original code. |
phadej
pushed a commit
to phadej/HsOpenSSL
that referenced
this pull request
Sep 13, 2019
Make prandInteger functions use BN_pseudo_rand_range
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review it very carefully and let me know where its broken so I can fix it. I can rebase the pull request to fix it. Currently it makes it compile but I have little confidence that its correct.