Using get-port to resolve a valid port if none is provided by user #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
derhuerst
reviewed
Oct 1, 2018
derhuerst
reviewed
Oct 1, 2018
derhuerst
reviewed
Oct 1, 2018
derhuerst
reviewed
Oct 1, 2018
Owner
|
Thanks! |
Owner
|
Thinking about it, it would make more sense though to search for a random port when running the server via |
Owner
|
ping @taylanken 😉 |
Owner
|
ping @taylanken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added function ensurePort that asynchronously returns a valid port number and uses get-port module to get a valid, free port if none is provided or if the provided port is not a valid number. Closes #1