do not chunk when performing beamforming#45
Open
popcornell wants to merge 2 commits intodesh2608:masterfrom
Open
do not chunk when performing beamforming#45popcornell wants to merge 2 commits intodesh2608:masterfrom
popcornell wants to merge 2 commits intodesh2608:masterfrom
Conversation
Contributor
Author
|
@kamo-naoyuki, did you had a chance to try ? @desh2608 can you merge ? I confirmed this does not impact the results. |
Owner
|
I am concerned that this may cause GPU OOMs when the segment is long and/or we are using a large number of channels. It may be better to have a CLI option to set bf chunking on/off (turned on by default). Could you make this change? |
Contributor
Author
|
Yes but then we need to also disable the channel selection inside the beamformer when the option is disabled. Or IDK beamforming part needs to be changed quite a lot to accomodate for chunking but only before the channel.selection |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as pointed out by @kamo-naoyuki, there are currently problems when doing the beamforming due to the fact that the a-posteriori SNR reference channel selection is performed for each freq chunk independently (and this requires a reduction over the freq axis).
The easy fix is to avoid to chunk frequencies when doing the beamfoming. Hopefully it is still ok and will not lead to OOMs