Skip to content

feat: Add welcome message#26

Draft
titouanfreville wants to merge 2 commits intomainfrom
feature/welcome_message
Draft

feat: Add welcome message#26
titouanfreville wants to merge 2 commits intomainfrom
feature/welcome_message

Conversation

@titouanfreville
Copy link
Collaborator

@titouanfreville titouanfreville commented May 6, 2021

As discord server admin, we would like to propose a custom message
to welcome any new member.

  • Add an admin role to discord guild on bot startup
  • Bot admin can customise message

More:

  • Add bandit check for security issue

@titouanfreville titouanfreville force-pushed the feature/welcome_message branch 3 times, most recently from e3e59e6 to 25d370e Compare May 7, 2021 16:43
- Current code architecture is too heavy for open source project
and do not let people easily in if they are not used to it.
We decided to refactor it to a simpler base witch can be learned
without pre requisites and let you code using your own habits.

- Enforce some tools to format code
- Add CONTRIBUTING rules and Makefile to ease setup, running && testing

This proposition looks a bit heavy for a simple hello world but it
should stay clean with more complex usecases.

It enforces concern separation as discord part should only filter event
before calling correct module entrypoint, dissociate services from
modules and allow core feature to stay core ^^
@titouanfreville titouanfreville force-pushed the feature/welcome_message branch 2 times, most recently from 569ac47 to 2ed41af Compare May 7, 2021 22:10
@titouanfreville titouanfreville changed the title feat!: Rework code architecture and propose an hello world. feat: Add welcome message May 7, 2021
@titouanfreville titouanfreville force-pushed the feature/welcome_message branch 2 times, most recently from 5cf3538 to 945ae4c Compare May 7, 2021 22:13
@titouanfreville titouanfreville marked this pull request as ready for review May 7, 2021 22:15
@titouanfreville titouanfreville marked this pull request as draft May 7, 2021 22:15
@titouanfreville titouanfreville force-pushed the feature/welcome_message branch 4 times, most recently from 22ccc46 to 4f810c4 Compare May 8, 2021 19:10
As discord server admin, we would like to propose a custom message
to welcome any new member.

- Add an admin role to discord guild on bot startup
- Bot admin can customise message

More:
- Add bandit check for security issue
@titouanfreville titouanfreville force-pushed the feature/welcome_message branch from 4f810c4 to 18a03a6 Compare May 9, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant