-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/login page #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feat/login page #14
Conversation
…vday_pwa into feat/login-page
+ remove firstname, name + add passwordconfirm + implement ValidatorFn for matching password Co-Authored-By: NemareLethiere <nemarelethiere@users.noreply.github.com>
|
For the api requests we should implement a basicservice which can be used across different servises.: |
| constructor(private http: HttpClient) { } | ||
|
|
||
| getAll() { | ||
| return this.http.get<User[]>(`${environment.apiUrl}/users`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API Endpoints should be moved into an enum
| </div> | ||
| <div class="form-group"> | ||
| <label for="password">Password</label> | ||
| <label for="password">Passwort</label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should generate components for inputs where label is only shown when a label is given by input. Input type, state (readonly ...) should be configurable too.
We build a small login page with this tutorial
We've already implemented:
Do not merge. This pr is just for the progress.