Issue 73/name conflict detection

.quality-baseline.json

@@ -219,12 +219,6 @@
       "singleUseVariable"
     ]
   },
-  "src/core/commands/rename-command.ts": {
-    "lastCommitId": "bf89440ad4d87ed9c05abccbdce0a584a374bedf",
-    "violations": [
-      "singleUseVariable"
-    ]
-  },
   "src/core/commands/select-command.ts": {
     "lastCommitId": "876773659621d2929ad9c16187ad30ab7dcc177b",
     "violations": [

src/core/commands/rename-command.ts

@@ -6,6 +6,8 @@ import { VariableLocator, VariableNodeResult } from '../locators/variable-locato
 import { RenameVariableTransformation } from '../transformations/rename-variable-transformation';
 import { LocationRange } from '../ast/location-range';
 import { NodeAnalyzer } from '../services/node-analyzer';
+import { VariableNameValidator } from '../services/variable-name-validator';
+import { ScopeAnalyzer } from '../services/scope-analyzer';
 
 export class RenameCommand implements RefactoringCommand {
   readonly name = 'rename';
@@ -15,15 +17,15 @@ export class RenameCommand implements RefactoringCommand {
   private consoleOutput!: ConsoleOutput;
   private astService!: ASTService;
   private variableLocator!: VariableLocator;
+  private nameValidator!: VariableNameValidator;
 
   async execute(file: string, options: CommandOptions): Promise<void> {
     this.validateOptions(options);
     this.astService = ASTService.createForFile(file);
     this.variableLocator = new VariableLocator(this.astService.getProject());
-    const sourceFile = this.astService.loadSourceFile(file);
-    const node = this.findTargetNode(options);
-    await this.performRename(node, options.to as string);
-    await this.astService.saveSourceFile(sourceFile);
+    this.nameValidator = new VariableNameValidator();
+    await this.performRename(this.findTargetNode(options), options.to as string);
+    await this.astService.saveSourceFile(this.astService.loadSourceFile(file));
   }
 
   private findTargetNode(options: CommandOptions): Node {
@@ -47,8 +49,9 @@ export class RenameCommand implements RefactoringCommand {
     NodeAnalyzer.validateIdentifierNode(node);
     const sourceFile = node.getSourceFile();
     const nodeResult = this.findVariableNodesAtPosition(node, sourceFile);
-    const transformation = this.createRenameTransformation(nodeResult, newName);
-    await transformation.transform(sourceFile);
+
+    this.validateNewName(nodeResult.declaration, newName);
+    await this.createRenameTransformation(nodeResult, newName).transform(sourceFile);
   }
 
   private findVariableNodesAtPosition(node: Node, sourceFile: SourceFile) {
@@ -71,4 +74,8 @@ export class RenameCommand implements RefactoringCommand {
   setConsoleOutput(consoleOutput: ConsoleOutput): void {
     this.consoleOutput = consoleOutput;
   }
+
+  private validateNewName(declarationNode: Node, newName: string): void {
+    this.nameValidator.generateUniqueName(newName, ScopeAnalyzer.getNodeScope(declarationNode));
+  }
 }

tests/fixtures/commands/rename/parameter-conflict.expected.err

@@ -0,0 +1 @@
+Variable name 'param' already exists in this scope. Please choose a different name.

tests/fixtures/commands/rename/parameter-conflict.expected.ts

@@ -0,0 +1,9 @@
+/**
+ * @description Test rename with parameter conflict
+ * @command refakts rename "[parameter-conflict.input.ts 7:11-7:12]" --to "param"
+ * @expect-error true
+ */
+function f(param: number) {
+    const x = 1;
+    return x + param;
+}

tests/fixtures/commands/rename/parameter-conflict.input.ts

@@ -0,0 +1,9 @@
+/**
+ * @description Test rename with parameter conflict
+ * @command refakts rename "[parameter-conflict.input.ts 7:11-7:12]" --to "param"
+ * @expect-error true
+ */
+function f(param: number) {
+    const x = 1;
+    return x + param;
+}

tests/fixtures/commands/rename/parent-scope-conflict.expected.err

@@ -0,0 +1 @@
+Variable name 'y' already exists in this scope. Please choose a different name.

tests/fixtures/commands/rename/parent-scope-conflict.expected.ts

@@ -0,0 +1,14 @@
+/**
+ * @description Test rename with parent scope conflict
+ * @command refakts rename "[parent-scope-conflict.input.ts 7:11-7:12]" --to "y"
+ * @expect-error true
+ */
+function f() {
+    const x = 1;
+    {
+        const y = 2;
+        {
+            return x;
+        }
+    }
+}

tests/fixtures/commands/rename/parent-scope-conflict.input.ts

@@ -0,0 +1,14 @@
+/**
+ * @description Test rename with parent scope conflict
+ * @command refakts rename "[parent-scope-conflict.input.ts 7:11-7:12]" --to "y"
+ * @expect-error true
+ */
+function f() {
+    const x = 1;
+    {
+        const y = 2;
+        {
+            return x;
+        }
+    }
+}

tests/fixtures/commands/rename/same-scope-conflict.expected.err

@@ -0,0 +1 @@
+Variable name 'y' already exists in this scope. Please choose a different name.

tests/fixtures/commands/rename/same-scope-conflict.expected.ts

@@ -0,0 +1,10 @@
+/**
+ * @description Test rename with same scope conflict
+ * @command refakts rename "[same-scope-conflict.input.ts 7:11-7:12]" --to "y"
+ * @expect-error true
+ */
+function f() {
+    const x = 1;
+    const y = 2;
+    return x + y;
+}

tests/fixtures/commands/rename/same-scope-conflict.input.ts

@@ -0,0 +1,10 @@
+/**
+ * @description Test rename with same scope conflict
+ * @command refakts rename "[same-scope-conflict.input.ts 7:11-7:12]" --to "y"
+ * @expect-error true
+ */
+function f() {
+    const x = 1;
+    const y = 2;
+    return x + y;
+}