Open
Conversation
Fixed the issue of index overflow caused by retrieving the root domain name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical IndexError: list index out of range that occurs when using Certbot to generate certificates for root domains (e.g., example.com).
Problem
In the get_domain_rr() function, the code splits the domain into tokens and removes the last two elements (the TLD and the main domain).
The original code then attempts to access tokens[0] to check for wildcard symbols without verifying if the list is empty, leading to a runtime crash.
Solution
Added a conditional check if tokens: before accessing tokens[0]. This ensures that if the list is empty (indicating a root domain), it skips the wildcard check and directly inserts the _acme-challenge prefix.
Verification Results
I have tested this fix in an Alibaba Cloud Function Compute (FC) environment: | Domain Input | DEVS_DOMAIN | Resulting RR | Status | | :--- | :--- | :--- | :--- | | Root Domain | opty.fun | _acme-challenge | Fixed | | Subdomain | www.opty.fun | _acme-challenge.www | Works | | Wildcard | *.opty.fun | _acme-challenge | Works |