feat: Support multi-domain certificates and improve DNS validation reliability#2
Open
inklife wants to merge 1 commit intodevsapp:mainfrom
Open
feat: Support multi-domain certificates and improve DNS validation reliability#2inklife wants to merge 1 commit intodevsapp:mainfrom
inklife wants to merge 1 commit intodevsapp:mainfrom
Conversation
inklife
commented
Feb 12, 2026
inklife
commented
- Update src/cert-generator/index.py to accept domainName as an array, enabling multi-domain certificate requests.
- Implement logic to parse SANs from existing certificates to ensure consistency during renewal.
- Refactor authenticator.py to always insert new DNS TXT records instead of updating, resolving issues with concurrent validations for subdomains.
- Add configurable DNS propagation wait time.
- Update cleanup.py and alidns/index.py to delete specific TXT records by value, preventing accidental deletion of other challenge records.
- Enhance logging and error handling for DNS operations.
…liability - Update src/cert-generator/index.py to accept domainName as an array, enabling multi-domain certificate requests. - Implement logic to parse SANs from existing certificates to ensure consistency during renewal. - Refactor authenticator.py to always insert new DNS TXT records instead of updating, resolving issues with concurrent validations for subdomains. - Add configurable DNS propagation wait time. - Update cleanup.py and alidns/index.py to delete specific TXT records by value, preventing accidental deletion of other challenge records. - Enhance logging and error handling for DNS operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.