fix(vector): Make construction pruning deterministic and align tests #9563
+152
−88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a small follow-up to @matthewmcneely's
matthewmcneely/fix-similarity-based-hnsw-indexingthat tightens the construction-time pruning path intok/hnsw/helper.go:addNeighbors.efConstruction(rather than relying on heap/slice side-effects)This is intended to be easy to cherrypick into the PR branch
Why
The directionality fix is the key part (and @matthewmcneely's PR nails that), but the existing pruning loop still had a couple of structure-level issues (heap initialisation/slice truncation semantics) that could make construction behaviour hard to reason about -- especially under similarity metrics
Testing
go test ./tok/hnsw -count=1main(per my comment) and stable miss-rate and expected build/query behaviour vs. fix(vector): Fix similarity-based HNSW search for cosine and dot product metrics #9559Checklist
Conventional Commits syntax, leading
with
fix:,feat:,chore:,ci:, etc.