This repository was archived by the owner on Jan 18, 2024. It is now read-only.
added support for user-defined path and mountable engines#9
Open
ingobecker wants to merge 2 commits intodhl:masterfrom
Open
added support for user-defined path and mountable engines#9ingobecker wants to merge 2 commits intodhl:masterfrom
ingobecker wants to merge 2 commits intodhl:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case you write a mountable enigine, there is a so called dummy directory(test/dummy/) which contains a dummy app to mount the engine during testing and development. With the introduced changes to erb2haml, it takes this additional path into account. I have added this path as a hardcoded default, because it's the default dir which rails creates when generating a new mountable engine. In case of rspec, the path to the dummy app will be
spec/dummy, but thats something the user has to explecitly define. Thats why i added the posibility to pass a user-defined search path to the rake task(as described in the README). I also refactored the rake file because there was a lot of redundancy. I hope that's ok ;)