Changes to mleibman since fork #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create README, delete .DS_Store and .gitignore it
Added another focus sink just after the grid content and set focus depending on the direction of keyboard navigation.
[BUG] Jquery UI Sortable Widget +1.9 init bugfix
The `:ui-sortable` pseudo-selector filters out the element if it hasn't been initialized as a Sortable.
Improve jQuery UI Sortable fix
Added a small distance delay on the sortable to prevent users from unintended triggering of the reordering. (Happens all the time i'm using slickgrid). i.e. the users tries to sort the column but fails since his mouse was still on the move a little bit and 1px is enough to trigger reordeing here. Please try, it still feels very responsive.
'hover' pseudo-event has been deprecated in jQuery 1.9.0, use of 'mouseenter' and 'mouseleave' instead.
Replace 'hover' deprecated pseudo-event
Add the distance delay to the header drag code.
$.browser object has been removed from jQuery 1.9.0
Use of navigator.userAgent instead of $.browser
Added distance to prevent users from unintended dragging of rows.
Distance for dragging
GitHub currently transforms the path into a blob-style URL for the wiki, which is a 404
Fix wiki link in README
numeric keycodes
{} for ifs
Shift+arrow keys support for selection
Based on the original pull request (#522) by ghiscoding. Deprecated DataVIew APIs (will continue to work): - .groupBy() - .setAggregators() New DataView APIs: - .getGrouping() - .setGrouping(groupingInfo) - .setGrouping([groupingInfo1, groupingInfo2, ...]) - .collapseAllGroups() - .collapseAllGroups(level) - .expandAllGroups() - .expandAllGroups(level) - .collapseGroup(groupingKey) - .collapseGroup(level1value, level2value, ...) - .expandGroup(groupingKey) - .expandGroup(level1value, level2value, ...) Grouping info options (for use in .setGrouping() calls): - getter - formatter - comparer - aggregators - aggregateCollapsed - aggregateChildGroups - collapsed New Group fields: - level - groups - groupingKey Also fixed 0-handling in default aggregators.
…that's the default behavior assumed by 'canCellBeActive'
Performance Improvement
…hift-click event.
for all example pages in github pages
Link to Github Source from examples
Temporarily comment out the code that deals with restoring focus on clicks outside the row until I find a better solution.
…selection changes (preserveHiddenOnSelectionChange)
Make DataView. syncGridSelection() return an event that notifies when an internal list of selected row ids changes.
Visible row count vs total row count in slick.pager.js
undo edit command doesn't trigger onCellChange event
bugfix column can grow larger than its maxwidth
…nk and grow operations. In some cases the prevTotal exceeded total (for grow) and was less than total (for shrink). The existing check simply checked if the 2 values were equal, but not if prevTotal had gone beyond the proper bounds, resulting in an infinite loop.
Improved infinite loop avoidance in autoSizeColumns()
Add a ‘lazyTotalsCalculation’ grouping info option (default = false) that delays the totals calculation until the item is accessed via getItem(index). This can dramatically improve the perceived performance of the DataView operations on very large datasets.
fixed an issue where the dataView variable was being accessed but didn't exist
Update README to match Wiki in identifying 6pac's fork as the most active
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets pull some of these in.