fix: disable firefox cache to test a potential root cause for the bui… #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegov
force-pushed
the
fix_integration_tests
branch
from
dd56be8 to
9ea5222
Compare
…ld failures The builds have worked briefly after changes that invalidate this cache, then failed again. While running some of these builds interactively to investigate this issue, I noticed they got auto-updated, I think this changed recently, and it's what's causing the builds to fail when caching the firefox builds, because each downloaded build will work with Marionette only once. What might happen is: - On the first buiild FF will start to download an update autommtically - We cached this FF installation - On the next build, Marionette won't be abe to connect to FF The reason why the second launch could be that the first run of FF was too short for the download to complete (I would say unlikely, I'm sure the devs account for the possibility of an incomplete download of the update) or maybe the update process needs to run during startup, preventing Marionette from connecting. If disabling the cache fixes the builds, it's likely the auto-update is the issue.
diegov
force-pushed
the
fix_integration_tests
branch
from
9ea5222 to
b66b104
Compare
Owner
Author
|
This confirms the issue, the proper fix is in #47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ld failures
The builds have worked briefly after changes that invalidate this cache, then failed again.
While running some of these builds interactively to investigate this issue, I noticed they got auto-updated, I think this changed recently, and it's what's causing the builds to fail when caching the firefox builds, because each downloaded build will work with Marionette only once. What might happen is:
The reason why the second launch could be that the first run of FF was too short for the download to complete (I would say unlikely, I'm sure the devs account for the possibility of an incomplete download of the update) or maybe the update process needs to run during startup, preventing Marionette from connecting.
If disabling the cache fixes the builds, it's likely the auto-update is the issue.
Testing #42