Fixed curl progress output included in responds#97
Open
Aadniz wants to merge 3 commits intodiepm:masterfrom
Open
Fixed curl progress output included in responds#97Aadniz wants to merge 3 commits intodiepm:masterfrom
Aadniz wants to merge 3 commits intodiepm:masterfrom
Conversation
This reverts commit febb7b5.
|
It is a nice idea to have, however I believe it should be implemented differently. My suggestion: create a configurable variable for it and by default it can be disabled. When the configuration variable is set - you enable it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without
curl --silence, it causes the respond to contain the progress of the request, like the example below:without silent
with silent
Using "cat" pipe as it gives the same result as the plugin does