fix: prevent sandbox Docker preflight from hanging indefinitely#789
Open
caoergou wants to merge 1 commit intodifferent-ai:devfrom
Open
fix: prevent sandbox Docker preflight from hanging indefinitely#789caoergou wants to merge 1 commit intodifferent-ai:devfrom
caoergou wants to merge 1 commit intodifferent-ai:devfrom
Conversation
…erent-ai#757) The `run_local_command_with_timeout` function could block indefinitely when joining pipe reader threads after killing a timed-out child process. This caused the UI to freeze on "Checking Docker..." during sandbox creation. Changes: - Replace unbounded `join()` with bounded `recv_timeout()` using channels - Add 2-second upper bound for pipe reader thread cleanup - Add telemetry logs around timeout/kill/join operations - Handle timeout and disconnect cases explicitly The fix ensures that `sandbox_doctor()` returns within a bounded time in all failure paths, preventing UI deadlocks.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@caoergou is attempting to deploy a commit to the 0 Finance Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #757
The
run_local_command_with_timeoutfunction could block indefinitely when joining pipe reader threads after killing a timed-out child process. This caused the UI to freeze on "Checking Docker..." during sandbox creation.Problem
When Docker preflight takes too long or stalls:
run_local_command_with_timeoutspawns stdout/stderr reader threadsjoin()join()can block foreversandbox_doctor()from returning, causing UI deadlockSolution
join()with boundedrecv_timeout()usingmpscchannelsREADER_JOIN_TIMEOUT_MS(2 seconds) as upper bound for thread cleanupTimeoutandDisconnectedcases explicitly with telemetry logsChanges
commands/orchestrator.rsTesting
rustfmt --checkAcceptance Criteria
refreshSandboxDoctor()returns within a bounded time in all failure paths