fix: prevent session loss when switching workspaces#790
Merged
benjaminshafii merged 2 commits intodifferent-ai:devfrom Mar 7, 2026
Merged
Conversation
Add guard to prevent clearing sidebar sessions when the session store temporarily returns empty during worker restart/reconnect. This fixes the issue where sessions disappear from the sidebar when switching between workspaces or refreshing the window. Fixes different-ai#750, different-ai#735
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@caoergou is attempting to deploy a commit to the 0 Finance Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Extract the guard logic from app.tsx into a testable pure function to prevent session loss during workspace switches. - Add `shouldUpdateSidebarSessions` to `lib/sidebar-sessions-guard.ts` - Add test script `scripts/sidebar-sessions-guard.mjs` with 7 test cases - Update app.tsx to use the extracted function - Add `test:sidebar-sessions-guard` script to package.json The guard prevents the sidebar from being cleared when the server temporarily returns an empty session list during worker restart/reconnect. Ref: different-ai#750
Contributor
Author
benjaminshafii
approved these changes
Mar 7, 2026
Member
benjaminshafii
left a comment
benjaminshafii
left a comment
There was a problem hiding this comment.
Reviewed locally: no malicious changes found, targeted guard test passes, and diff is scoped to sidebar session update logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
In
packages/app/src/app/app.tsx, acreateEffectsyncs the session store to the sidebar. When a worker restarts or the user switches workspaces:loadSessions()is calledreconcile()Fix
Added a guard that prevents clearing existing sidebar sessions when the session store becomes empty for that workspace. This preserves existing sessions during the reconnection window while still allowing:
Test Plan
Fixes #750
Fixes #735