fix(app): add type declaration for local-file-path.impl.js#791
Merged
benjaminshafii merged 1 commit intodifferent-ai:devfrom Mar 7, 2026
Merged
fix(app): add type declaration for local-file-path.impl.js#791benjaminshafii merged 1 commit intodifferent-ai:devfrom
benjaminshafii merged 1 commit intodifferent-ai:devfrom
Conversation
Add a .d.ts file to resolve TS7016 error when importing a JavaScript module without type declarations. This is a minimal fix that doesn't require modifying tsconfig.json settings.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@caoergou is attempting to deploy a commit to the 0 Finance Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
benjaminshafii
approved these changes
Mar 7, 2026
Member
benjaminshafii
left a comment
benjaminshafii
left a comment
There was a problem hiding this comment.
Reviewed locally: change is limited to a single .d.ts declaration, typecheck passes, and local file path script tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
local-file-path.impl.d.tstype declaration file to resolve TS7016 error.jsfile without type declarationsProblem
TypeScript compilation failed with:
Solution
Added a minimal
.d.tsfile declaring the function signature instead of modifying tsconfig.jsonallowJssetting. This is the least invasive approach.Test plan
pnpm typecheckpasses with no errors