fix: sandbox probe diagnostics and proc-exit fast-fail (#762)#794
Open
ZeusCraft10 wants to merge 1 commit intodifferent-ai:devfrom
Open
fix: sandbox probe diagnostics and proc-exit fast-fail (#762)#794ZeusCraft10 wants to merge 1 commit intodifferent-ai:devfrom
ZeusCraft10 wants to merge 1 commit intodifferent-ai:devfrom
Conversation
…ifferent-ai#762) The detached orchestrator startup discarded the CommandChild and event receiver from spawn(), losing all sidecar output and making timeout errors opaque ("Connection refused" with no context). - Capture (rx, child) from spawn and drain stdout/stderr into a ring buffer via an async task. - Detect early process exit via AtomicBool and fail fast with the last orchestrator output instead of waiting the full 90s timeout. - Add structured stage logs: spawn (port/bind info), first-health- attempt, proc-exit-early, and timeout with orchestratorOutput in the emitted progress event payload. - Add unit tests for snapshot_proc_output helper. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@ZeusCraft10 is attempting to deploy a commit to the 0 Finance Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
orchestratorOutputin progress event payloads.Why
CommandChildand event receiver fromspawn(), losing all sidecar output.Connection refused (os error 61)with no context about whether the process crashed, failed to bind, or hit a readiness issue.Issue
Scope
packages/desktop/src-tauri/src/commands/orchestrator.rs—orchestrator_start_detached()function and newsnapshot_proc_output()helper.Out of scope
orchestratorOutputfield from progress events.Testing
Ran
rustfmt --edition 2021 --checkon the modified file — passes clean.cargo checkcould not complete due to pre-existing Windows linker environment issue (OneDrive path with spaces breakslink.exe). Not caused by this PR — affects all Rust compilation on this machine.Result
rustfmtformatting checkcargo check/cargo testblocked by Windowslink.exepath resolution conflict (pre-existing)CI status
cargo checkblocked by Windows linker issue (not PR-related)Manual verification
Orchestrator output (last lines):section andstage: "timeout"in the progress event.Evidence
Risk
(rx, child)fromspawn()instead of discarding — theCommandChildis now held alive inside the async drain task, which is consistent with how all other sidecar spawns in the codebase work (seecommands/engine.rs,orchestrator/mod.rs).Rollback