Conversation
09af245 to
5e76a84
Compare
OgreSound
requested changes
Mar 11, 2026
Contributor
OgreSound
left a comment
There was a problem hiding this comment.
Ei noita kahta buildia voi ainakaan noin suoraviivaisesti yhdistää nähdäkseni. ECR:ään ei pusketa dependabot imageja, ja githubiin voidaan ( nyt asettujen github app oikeuksien puolesta) ja tarvitsee (integraatio-testien näkökulmasta) puskea vain integraatio-testien piirissä olevien repojen imaget. ilmeisesti tag-latest controlloi edelleen github tägäystä joten se ehkä kunnossa, mutta kun tuo dependabot 'if'-ehto nyt kontrolloi koko build steppiä niin dependabot haaroille ajautuisi integraatiotestit.
scope lisäyksestä ei varmaan haittaa ole mutta niin kauan kun yksi repo pakkaa vaan yhtä image-namea niin tuolla ei taida olla mitään merkitystä
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.