Fix two use-after-frees #449
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a use-after free where a dangling pointer would be left in the ValidSocks klist.
This bug was half-addressed last year in commit 9b6c641, but conn could still be a dangling pointer if ongoing==TRUE.
Contributor
Author
|
moved to mailing list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat-minimal repros for the two crashes are in attached zip archive:
crash-dillo.zip
I've only tested these on x86_64 Void Linux, but they reproduce quite reliably here.
note that these repros use external web servers
(ash-speed.hetzner.com, detectportal.firefox.com, 142.251.45.142 aka google.com),
and so aren't ready to be automated tests.
Zip archive also has logs of the two crashes with address sanitizer reporting.