Skip to content

Conversation

@pcwalton
Copy link
Contributor

The biggest change here is that doing the same query twice, one mutably and one
immutably, is no longer needed, once bevyengine/bevy#2305 lands. Before that
lands, however, this upgrade is actually impossible to do safely, since the
q0/q0_mut distinction is gone and therefore it's impossible to implement
the Rapier component traits on Bevy queries. (This is filed upstream as
bevyengine/bevy#2744.) Therefore, this upgrade has to wait until that Bevy PR
lands.

Other minor changes:

  • Light has been renamed to PointLight.

  • App::build() is now App::new(), and AppBuilder is now App.

  • glam has been upgraded upstream.

The biggest change here is that doing the same query twice, one mutably and one
immutably, is no longer needed, once bevyengine/bevy#2305 lands. Before that
lands, however, this upgrade is actually impossible to do safely, since the
`q0`/`q0_mut` distinction is gone and therefore it's impossible to implement
the Rapier component traits on Bevy queries. (This is filed upstream as
bevyengine/bevy#2744.) Therefore, this upgrade has to wait until that Bevy PR
lands.

Other minor changes:

* `Light` has been renamed to `PointLight`.

* `App::build()` is now `App::new()`, and `AppBuilder` is now `App`.

* `glam` has been upgraded upstream.
@acycliczebra
Copy link

If this change is based on the main branch of bevy, should it not use the correct dependency rather than version 0.5.0?

@MiniaczQ
Copy link

MiniaczQ commented Oct 8, 2021

Bump, I'm also confused why it's still dependent on bevy 0.5
It'd be good to include bevy main branch in crates-io patch

@MiniaczQ
Copy link

MiniaczQ commented Oct 8, 2021

I've tried building this using a bevy PR to fix the mentioned problem.
This PR is a bit old and all components need to have Component derived for them with the newest bevy.
In fact, it makes up 719 out of 724 compilation errors that I'm getting.
Sadly I cannot fix it myself since macros are used in many places and I have no experience with those.
The other 5 errors are FilterFetch not being implemented for certain objects.
Also, here's the cargo.toml that I used:

[dependencies]
bevy = { git = "https://github.com/bevyengine/bevy", branch = "main" }
bevy_rapier2d = { git = "https://github.com/pcwalton/bevy_rapier", branch = "bevy0.6up" }

[patch.crates-io]
bevy = { git = "https://github.com/Guvante/bevy/", branch = "iter_for_mutable_query" }

@deontologician
Copy link

I've incorporated this branch and some more fixes into #91 and I was able to get things compiling again

@seurimas
Copy link

seurimas commented Jan 8, 2022

0.6.0 just released, and it seems that the ECS changes will require broader changes than are included in this PR. One item of note is that Component will need to be derived or implemented manually now.

@sebcrozet
Copy link
Member

Thank you for this PR @pcwalton! I merged #102 (which started with the content of this PR I think).

@sebcrozet sebcrozet closed this Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants