-
-
Notifications
You must be signed in to change notification settings - Fork 274
Update to Bevy 0.6 main branch. #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The biggest change here is that doing the same query twice, one mutably and one immutably, is no longer needed, once bevyengine/bevy#2305 lands. Before that lands, however, this upgrade is actually impossible to do safely, since the `q0`/`q0_mut` distinction is gone and therefore it's impossible to implement the Rapier component traits on Bevy queries. (This is filed upstream as bevyengine/bevy#2744.) Therefore, this upgrade has to wait until that Bevy PR lands. Other minor changes: * `Light` has been renamed to `PointLight`. * `App::build()` is now `App::new()`, and `AppBuilder` is now `App`. * `glam` has been upgraded upstream.
|
If this change is based on the main branch of bevy, should it not use the correct dependency rather than version 0.5.0? |
|
Bump, I'm also confused why it's still dependent on bevy 0.5 |
|
I've tried building this using a bevy PR to fix the mentioned problem. [dependencies]
bevy = { git = "https://github.com/bevyengine/bevy", branch = "main" }
bevy_rapier2d = { git = "https://github.com/pcwalton/bevy_rapier", branch = "bevy0.6up" }
[patch.crates-io]
bevy = { git = "https://github.com/Guvante/bevy/", branch = "iter_for_mutable_query" } |
|
I've incorporated this branch and some more fixes into #91 and I was able to get things compiling again |
|
0.6.0 just released, and it seems that the ECS changes will require broader changes than are included in this PR. One item of note is that Component will need to be derived or implemented manually now. |
The biggest change here is that doing the same query twice, one mutably and one
immutably, is no longer needed, once bevyengine/bevy#2305 lands. Before that
lands, however, this upgrade is actually impossible to do safely, since the
q0/q0_mutdistinction is gone and therefore it's impossible to implementthe Rapier component traits on Bevy queries. (This is filed upstream as
bevyengine/bevy#2744.) Therefore, this upgrade has to wait until that Bevy PR
lands.
Other minor changes:
Lighthas been renamed toPointLight.App::build()is nowApp::new(), andAppBuilderis nowApp.glamhas been upgraded upstream.