feat: del brand color for use diplodoc/themes in other proejcts#772
feat: del brand color for use diplodoc/themes in other proejcts#772
Conversation
Summary
🎉 No failed tests in this run. Github Test Reporter by CTRF 💚 |
Summary
🎉 No failed tests in this run. Github Test Reporter by CTRF 💚 |
| @@ -0,0 +1,3 @@ | |||
| @use 'base'; | |||
There was a problem hiding this comment.
create this temporal file because extensions don't have scss version
next step create scss version in extenssions, delete this file
then we can use yfm.scss in places like this - https://github.com/diplodoc-platform/components/pull/468/files
Summary
🎉 No failed tests in this run. Github Test Reporter by CTRF 💚 |
| background-color: var(--yfm-color-table-head-background); | ||
| background-color: var( | ||
| --yfm-color-table-row-background, | ||
| var(--yfm-color-table-row-background-private) | ||
| ); |
There was a problem hiding this comment.
Variables like --yfm-color-table-* are public CSS API of YFM tables.
Plz, bring back use of these variables.
Otherwise, this PR contains breaking changes.
There was a problem hiding this comment.
fix it , and add new tokens in themes library diplodoc-platform/themes#8
Summary
🎉 No failed tests in this run. Github Test Reporter by CTRF 💚 |
src/scss/_inline-code.scss
Outdated
| box-shadow: 0 0 0 1px | ||
| var( | ||
| --yfm-color-term-dfn-pseudo-shadow, | ||
| var(--yfm-color-term-dfn-presudo-shadow-private) |
There was a problem hiding this comment.
in two places in this pr - "presudo" instead of "pseudo"
Summary
🎉 No failed tests in this run. Github Test Reporter by CTRF 💚 |
4 participants
I added the scss folder to the final build, this is necessary so that the end user can apply a mixin with a theme from @diplodoc/themes, otherwise if you use css import, the colors will already be taken from the variables. Now the brand file is not needed, as the branding will be from the @diplodoc/themes library. Examples in the neighboring PR diplodoc-platform/components#468