-
Notifications
You must be signed in to change notification settings - Fork 10
464 implement frontend javascript testing #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Fixes #464 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@AdrianDAlessandro I moved the node documentation to a separate README.md inside the node directory. This seems to have broken the mkdocs build. I tried looking through the code and docs but I can't see how to add this file. |
| ```bash | ||
| npm run styles:expanded | ||
| ``` | ||
| See [node/README.md](https://github.com/direct-framework/direct-webapp/blob/main/node/README.md) for details on working with the NPM-based frontend asset pipeline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [linkspector] reported by reviewdog 🐶
Cannot reach https://github.com/direct-framework/direct-webapp/blob/main/node/README.md Status: 404
Co-authored-by: Adrian D'Alessandro <a.dalessandro@imperial.ac.uk>
f62472c to
053c4be
Compare
|
@AdrianDAlessandro FYI I've rebased this onto the main branch. |
Description
Some tidying up of the frontend node code related to #529
Fixes #529
Type of change
Key checklist
python -m pytest)mkdocs serve)pre-commit run --all-files)Further checks