Skip to content

Conversation

@sbland
Copy link
Contributor

@sbland sbland commented Oct 29, 2025

Description

Some tidying up of the frontend node code related to #529

Fixes #529

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Technical work (non-breaking, change which is work as part of a new feature)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. mkdocs serve)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@sbland
Copy link
Contributor Author

sbland commented Oct 29, 2025

Fixes #464

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@sbland
Copy link
Contributor Author

sbland commented Oct 29, 2025

@AdrianDAlessandro I moved the node documentation to a separate README.md inside the node directory. This seems to have broken the mkdocs build. I tried looking through the code and docs but I can't see how to add this file.

@sbland sbland self-assigned this Oct 29, 2025
@sbland sbland requested a review from davehorsfall October 29, 2025 11:39
```bash
npm run styles:expanded
```
See [node/README.md](https://github.com/direct-framework/direct-webapp/blob/main/node/README.md) for details on working with the NPM-based frontend asset pipeline.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [linkspector] reported by reviewdog 🐶
Cannot reach https://github.com/direct-framework/direct-webapp/blob/main/node/README.md Status: 404

@sbland sbland force-pushed the 464-implement-frontend-javascript-testing branch from f62472c to 053c4be Compare November 27, 2025 19:41
@sbland
Copy link
Contributor Author

sbland commented Nov 27, 2025

@AdrianDAlessandro FYI I've rebased this onto the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋 Backlog

Development

Successfully merging this pull request may close these issues.

Frontend Javascript and Dataviz amends to support contributors

3 participants