feat(seo-plugin): i18n support for UI components and fix favicon infinite loop (#299, #300)#301
Open
khuepm wants to merge 4 commits intodirectus-labs:mainfrom
Open
feat(seo-plugin): i18n support for UI components and fix favicon infinite loop (#299, #300)#301khuepm wants to merge 4 commits intodirectus-labs:mainfrom
khuepm wants to merge 4 commits intodirectus-labs:mainfrom
Conversation
This was referenced Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces two major enhancements and fixes for the
seo-pluginextension, addressing both UI localization capability and a performance bug during search preview rendering.Resolves #299
Resolves #300
Changes Made
1. Multi-language (i18n) Support
$t()translation method across all Vue components (tabs, labels, field titles, placeholders, hints, and error notices).seo_plugin.prefix.vi-VNto handle these translation pairs.mergeLocaleMessage()directly into the main Vue bundle via src/lang/index.ts to ensure translations work seamlessly within the Directus Extension bundle constraints.2. SearchPreview Favicon Infinite Loop Fix
window.location.originloop query due to missing error boundaries.@errorevent handler (handleFaviconError) to correctly capture image load failures.showFavicon = false) instead of continually fetching.Verification
seo-plugininterface actively changing between English and Vietnamese interface modes within a local Directus environment.npm run buildsucceeds correctly with the translations bundled within app.js and api.js.Checklist
dist/elements.