Add Docker Hub publishing to CI workflow#373
Open
ZobbeLunar wants to merge 2 commits intodiscord:mainfrom
Open
Add Docker Hub publishing to CI workflow#373ZobbeLunar wants to merge 2 commits intodiscord:mainfrom
ZobbeLunar wants to merge 2 commits intodiscord:mainfrom
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019c8afe-fc10-7398-a80c-5b05df734eec Co-authored-by: Amp <amp@ampcode.com>
somethingnew2-0
requested changes
Feb 23, 2026
| secrets: | | ||
| "SENTRY_ORG=${{ secrets.SENTRY_ORG }}" | ||
| "SENTRY_PROJECT=${{ secrets.SENTRY_PROJECT }}" | ||
| "SENTRY_AUTH_TOKEN=${{ secrets.SENTRY_AUTH_TOKEN }}" |
Collaborator
There was a problem hiding this comment.
We'll want to make publishing to Dockerhub a separate flow as we don't want this SENTRY_AUTH_TOKEN pushed to the public
Author
There was a problem hiding this comment.
We have now reverted the docker-image.yml to its original state and created a seperate workflow in docker-hub.yml
Amp-Thread-ID: https://ampcode.com/threads/T-019c8ed3-435b-71af-88fa-cca3e8b96f7c Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #338
This PR adds Docker Hub publishing alongside the existing Google Artifact Registry push in the Docker Image CI workflow.
Changes
docker/login-action@v3withDOCKERHUB_USERNAMEandDOCKERHUB_TOKENsecretsdiscord/access:latestanddiscord/access:${{ github.sha }}) to the existing build-push step so the image is built once and pushed to both registriesRequired Setup
The following repository secrets need to be configured before this will work:
DOCKERHUB_USERNAME— Docker Hub usernameDOCKERHUB_TOKEN— Docker Hub access token (create one at https://hub.docker.com/settings/security)The Docker Hub repository
discord/accessshould also be created beforehand.