Fix infinity loop when max_size is zero#8
Open
defacedvr wants to merge 2 commits intodiscord:masterfrom
Open
Conversation
Max_size should be non_neg_integer Explicitly handle max_size=0 and do nothing but return same struct
Author
|
Hi. What you think about such changes? I found it pretty usable some times to create deque with max_size=0 and use as bounded queue without worries. Anyway, currently it goes to infinity loop, when max_size <= 0 |
|
Can you update tests? |
Author
|
Sure. I'll add some tests a little bit later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Max_size should be non_neg_integer
Explicitly handle max_size=0 and do nothing but return same struct