Fix mypy strict mode and ruff lint errors#3
Merged
harumaki4649 merged 3 commits intomainfrom Jan 24, 2026
Merged
Conversation
Co-authored-by: harumaki4649 <83683593+harumaki4649@users.noreply.github.com>
Co-authored-by: harumaki4649 <83683593+harumaki4649@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix mypy and lint errors in ci.yml
Fix mypy strict mode and ruff lint errors
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI was failing on
tox -e lintandtox -e typedue to missing type annotations and style violations.Changes
Type annotations (mypy --strict compliance):
-> Nonefor__init__, specific types for others)Optionalby explicitly typing defaults:data: Optional[Dict[str, Any]] = NoneDict[str, Any],List[Any],Type[Any]cast()calls where_validate_base()returns lose type specificitybuiltins.strin type hints withinVBuilderclass to disambiguate from thestr()methodLinting (ruff compliance):
==toisfor built-in typesTechnical Note
The name shadowing issue was subtle - mypy correctly flagged that
Dict[str, Any]within theVBuilderclass scope could ambiguously refer to either the built-instrtype or theVBuilder.str()method:Using
builtins.strexplicitly resolves the ambiguity.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.