Expose multiple headers with the same name in responses#1747
Open
nviliunov-evolution-throwaway wants to merge 2 commits intodisneystreaming:series/0.18from
Open
Expose multiple headers with the same name in responses#1747nviliunov-evolution-throwaway wants to merge 2 commits intodisneystreaming:series/0.18from
nviliunov-evolution-throwaway wants to merge 2 commits intodisneystreaming:series/0.18from
Conversation
|
|
kubukoz
reviewed
Jun 6, 2025
| val headers = res.headers.headers | ||
| .map(h => CaseInsensitive(h.name.toString) -> Seq(h.value)) | ||
| .toMap | ||
| .groupBy(h => CaseInsensitive(h.name.toString)) |
Member
There was a problem hiding this comment.
question: wait, we've been silently dropping repeated headers in responses all this time? wow.
Member
There was a problem hiding this comment.
at least this would only happen on clients...
however, res.headers should already have a MultiMap-like representation. Let's use that instead of our own grouping, if possisble.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist (not all items are relevant to all PRs)