Remove deprecations for 0.19#1781
Open
stewSquared wants to merge 2 commits intodisneystreaming:series/0.19from
Open
Remove deprecations for 0.19#1781stewSquared wants to merge 2 commits intodisneystreaming:series/0.19from
stewSquared wants to merge 2 commits intodisneystreaming:series/0.19from
Conversation
|
|
stewSquared
commented
Jul 21, 2025
| ) extends CachedSchemaCompiler.DerivingImpl[Encoder] | ||
| with EncoderCompiler { | ||
|
|
||
| @deprecated |
Author
There was a problem hiding this comment.
Just noting this didn't have a message or version in case that warrants scrutiny.
| def this(cache: CompilationCache[DocumentEncoder]) = | ||
| this(cache, explicitDefaultsEncoding = false) | ||
|
|
||
| @deprecated |
Author
There was a problem hiding this comment.
Just noting this didn't have a message or version in case that warrants scrutiny.
stewSquared
force-pushed
the
remove-deprecations-for-0.19
branch
2 times, most recently
from
b8e03cc to
a08ca1d
Compare
kubukoz
reviewed
Jul 21, 2025
| test("Document encoder - timestamp defaults") { | ||
| val result = Document.Encoder | ||
| .withExplicitDefaultsEncoding(false) | ||
| .withFieldFilter(FieldFilter.Default) |
Member
There was a problem hiding this comment.
nitpick: since it's the default, we can just skip this line. Applies to both cases
Member
|
Normally I'd only get to such tasks once we're relatively close to that 0.19 release, but it doesn't hurt so let's go with it :) |
stewSquared
force-pushed
the
remove-deprecations-for-0.19
branch
from
a08ca1d to
6854aee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1330
PR Checklist (not all items are relevant to all PRs)
Added unit-tests (for runtime code)Added bootstrapped code + smoke tests (when the rendering logic is modified)Added build-plugins integration tests (when reflection loading is required at codegen-time)Added alloy compliance tests (when simpleRestJson protocol behaviour is expanded/updated)Updated dynamic module to match generated-code behaviourAdded documentationI imagine updating the changelog is unnecessary if the deprecations were previously mentioned.