[0.19] Render fields marked nullable as smithy4s.Nullable rather than Option#1810
Open
stewSquared wants to merge 4 commits intodisneystreaming:series/0.19from
Open
Conversation
stewSquared
changed the title
stewSquared
force-pushed
the
APIREG-321-render-nullable-as-nullable
branch
2 times, most recently
from
ebd8470 to
4b79324
Compare
stewSquared
commented
Aug 20, 2025
| val definition = contents.find(_.contains("final case class NullableExample")).get | ||
|
|
||
| assert( | ||
| definition.contains("nullableString: Nullable[String]"), |
Author
There was a problem hiding this comment.
So, this test already passes before my changes to Renderer.scala and ToLine.scala. I don't understand this yet, because I don't know where else they would found and rendered as Nullable.
The other test is for sparse list and map types, which can have nullable elements. Those were previously rendered as Option.
stewSquared
force-pushed
the
APIREG-321-render-nullable-as-nullable
branch
from
0b15191 to
4b79324
Compare
stewSquared
force-pushed
the
APIREG-321-render-nullable-as-nullable
branch
2 times, most recently
from
1cd004e to
d697707
Compare
stewSquared
force-pushed
the
APIREG-321-render-nullable-as-nullable
branch
from
d697707 to
e3b9c40
Compare
Member
|
suggestion: let's do it in 0.18 with a Could even have a metadata setting like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist (not all items are relevant to all PRs)
Added build-plugins integration tests (when reflection loading is required at codegen-time)Added alloy compliance tests (when simpleRestJson protocol behaviour is expanded/updated)