Conversation
Gary-Distinctioncoding
left a comment
Gary-Distinctioncoding
left a comment
There was a problem hiding this comment.
Overall structure is good, but try avoid use inline-css and stylesheet at the same time, this will cause poor maintainability. Also, try to add structured sections like left-section and right-section inside the flex container
| </head> | ||
|
|
||
| <body> | ||
| <div class="bgimage"> |
There was a problem hiding this comment.
for convention naming for css, use kebab format. bgimage ->bg-image
| <div class="text" style="font-weight: 700"> | ||
| Welcome to Paint Quote System | ||
| </div> | ||
| <div class="text">————————————————</div> |
There was a problem hiding this comment.
can use ::after and border line to replace hard code content
| cupidatat excepteur duis mo | ||
| </div> | ||
| </div> | ||
| <div style="width: 150px;"></div> |
There was a problem hiding this comment.
I understand what this does, but try to use a relative unit % to control the container's width proportion
|
|
||
| <body> | ||
| <div class="bgimage"> | ||
| <img src="bgi.png" alt="" /> |
There was a problem hiding this comment.
good implementation, there is background-image attribute to set the background image, it can be used to avoid absolute positon
2 participants
No description provided.