Open
Conversation
Gary-Distinctioncoding
left a comment
Gary-Distinctioncoding
left a comment
There was a problem hiding this comment.
Overall is good, Consider using more meaningful class names, e.g. left-section and right-section instead of left and card. Also, try to control the gaps in flexbox for responsive design in your next homework
| } | ||
|
|
||
| .left { | ||
| text-align: c |
| <div class="page"> | ||
| <div class="left"> | ||
| <h1>Welcome to Paint Quote System</h1> | ||
| <div class="line"></div> |
There was a problem hiding this comment.
Can use ::after to avoid adding an additional element, as ::after is a pseudo-element that belongs to an element, so it can be attached to the h1
Comment on lines
+24
to
+39
| <div class="form-group"> | ||
| <label for="name">Your name</label> | ||
| <input id="name" type="text" placeholder="Enter your name" /> | ||
| </div> | ||
|
|
||
| <div class="form-group"> | ||
| <label for="phone">Phone number</label> | ||
| <input id="phone" type="tel" placeholder="Enter your phone number" /> | ||
| </div> | ||
|
|
||
| <div class="form-group"> | ||
| <label for="dulux">Dulux account</label> | ||
| <input id="dulux" type="text" placeholder="Enter your Dulux account" /> | ||
| </div> | ||
|
|
||
| <button type="button">Sign up</button> |
There was a problem hiding this comment.
Can wrap all the inputs and button in a form element for better practice, as browsers havedefault behaviours for form element
Comment on lines
+14
to
+20
| .page { | ||
| display: flex; | ||
| justify-content: space-between; | ||
| align-items: center; | ||
| padding: 40px; | ||
| min-height: 100vh; | ||
| } |
There was a problem hiding this comment.
- usually min-height is set on the body element, as every page has body element but not every page has .page class
- can set a max-width as the current space-between causes the left and card to be too far apart on large screens, or you can use gap or relative unit (%) for better pracrtice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.