Open
Conversation
| body{ | ||
| font-family: sans-serif; | ||
| height: 100vh; | ||
| background-image: url("20251114160805_20251115030208.png"); |
There was a problem hiding this comment.
can rename the file to a meaningful name to understand whta this static resource is,
you can put the background image on a container not direct;y set on body element, willl cause performance issues
There was a problem hiding this comment.
overall function is good, you can validate the inputs when input changes, if all validation passes, then enable the submit button, this will improve user experience.
Also, try to use toast or put the error message near the input field instead of using window.alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.