Open
Conversation
Gary-Distinctioncoding
left a comment
Gary-Distinctioncoding
left a comment
There was a problem hiding this comment.
Overall is good, if you want to move an element, try to add padding on its parent element to replace the margin on itself.
Some uses of the units are wrong, please refer to the class notes.
Comment on lines
+31
to
+50
| <div class="input-group"> | ||
| <label for="name">Your name</label> | ||
| <input type="text" id="name" placeholder="Enter your name" /> | ||
| </div> | ||
| <div class="input-group"> | ||
| <label for="phone">Phone number</label> | ||
| <input | ||
| type="text" | ||
| id="phone" | ||
| placeholder="Enter your phone number" | ||
| /> | ||
| </div> | ||
| <div class="input-group"> | ||
| <label for="dulux">Dulux account</label> | ||
| <input | ||
| type="text" | ||
| id="dulux" | ||
| placeholder="Enter your Dulux account" | ||
| /> | ||
| </div> |
There was a problem hiding this comment.
try to use toast or put the error message near the input fields, should not use window.alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.