Open
Conversation
Gary-Distinctioncoding
left a comment
Gary-Distinctioncoding
left a comment
There was a problem hiding this comment.
I saw you use a lot of vw units for width, which is not a proper method. You should use px or % for width instead. Image the web page is open in a mobile browser, 30vw is 1/3 of the screen width
Comment on lines
+39
to
+48
| <div class="form_group"> | ||
| <label for="account">Dulux account</label> | ||
| <input type="text" id="account" name="account" placeholder="Enter your Dulux account"> | ||
| <div> | ||
| <button class="sign_button"> | ||
| Sign up | ||
| </button> | ||
| </div> | ||
| <p>Already have an account? <a href="#">Sign in</a></p> | ||
| </div> |
There was a problem hiding this comment.
opening tag and closing tag is not matched
Comment on lines
+28
to
+32
| .title-line { | ||
| width: 36.5vw; | ||
| height: 2px; | ||
| background-color: rgb(0, 65, 96); | ||
| } |
There was a problem hiding this comment.
you can use ::after or a border line to replace
| color: rgb(0, 65, 96); | ||
| font-size: 1.3rem; | ||
| font-weight: 300; | ||
| width: 36vw; |
There was a problem hiding this comment.
no need width for an block displayed element
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your time and guidance.
Junyi(Joey) Hou