Open
Conversation
Gary-Distinctioncoding
left a comment
Gary-Distinctioncoding
left a comment
There was a problem hiding this comment.
Overall is good, but some elements' width are not necessary to set
Comment on lines
+25
to
+38
| <div> | ||
| <label for="username">Your name</label> | ||
| <input type="text" id="username" placeholder="Enter your name"> | ||
| </div> | ||
|
|
||
| <div> | ||
| <label for="phone">Phone number</label> | ||
| <input type="text" id="phone" placeholder="Enter your phone number"> | ||
| </div> | ||
|
|
||
| <div> | ||
| <label for="account">Dulux account</label> | ||
| <input type="text" id="account" placeholder="Enter your Dulux account"> | ||
| </div> |
There was a problem hiding this comment.
all the input elements miss name attribute, this is very important
Comment on lines
+25
to
+26
| margin-left: -40px; | ||
| margin-top: -35px; |
There was a problem hiding this comment.
very bad practice to move the position of the left-section to the place you want, margin it is the distance between element, not to move an element
Comment on lines
+22
to
+23
| flex: 1; | ||
| width: 100%; |
There was a problem hiding this comment.
flex: 1 的作用是让子元素平分父容器的可用空间， width不需要设置
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you!