Open
Conversation
Gary-Distinctioncoding
left a comment
Gary-Distinctioncoding
left a comment
There was a problem hiding this comment.
命名规范：使用kebab-case，eg. .left_panel -> .left-panel
注意%的unit, 是根据的父元素的宽高的百分之多少进行计算，前提是父元素要有合理的宽高
Comment on lines
+20
to
+28
| .signup_form { | ||
| height: 36vh; | ||
| width: 25vw; | ||
| max-width: 350px; | ||
| background-color: white; | ||
| padding: 10px 30px; | ||
| box-shadow: 0 4px 15px rgba(0, 0, 0, 0.3); | ||
| border-radius: 8px; | ||
| } |
There was a problem hiding this comment.
should not set a height, the conent in this element will cause overflow
| <div class="main_login"> | ||
| <div class="left_panel"> | ||
| <div class="welcome_message"> | ||
| <H2 class="welcome_title">Welcome to Paint Quote System</H2> |
There was a problem hiding this comment.
head tag should be small case h2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.