Open
Conversation
Gary-Distinctioncoding
left a comment
Gary-Distinctioncoding
left a comment
There was a problem hiding this comment.
Look at your naming of class and id, I suggest you give a more meaning names for example border->divider, welcome -> welcome-header
Also, you are using mixed naming convention. I saw .SignArea, .signButton, .Phone-number, .Dulux-Account, please use a consistant naming convention (normally kebab-case)
Comment on lines
+16
to
+19
| <div class="signForm item"> | ||
| <div id="SignUp">Sign Up</div> | ||
| <div id="SignIntro">Enter details to create your account</div> | ||
| </div> |
There was a problem hiding this comment.
you should use label tag for input title
Comment on lines
+71
to
+77
| .Name, | ||
| .Phone-number, | ||
| .Dulux-Account{ | ||
| height: 15%; | ||
| margin-bottom: 10px; | ||
| color: #AAAAAA; | ||
| } |
There was a problem hiding this comment.
can use one class name for simplify
| align-items: center; | ||
|
|
||
| height: 50vh; | ||
| width: 60vh; |
There was a problem hiding this comment.
vh is viewport height, width should use vw (viewport width)
and as a container, its height should fit its content, you set a height will cause content overflow
| height: 100vh; | ||
| } | ||
| #border{ | ||
| border: 1px solid ; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.