Open
Conversation
| <div className="form-field"> | ||
| <button type="submit" | ||
| className="submit-btn" | ||
| disabled={typeof btnDisabled === 'function' ? btnDisabled() : btnDisabled} |
There was a problem hiding this comment.
a little bit complicated and not rigorous, can directly pass passwordMatch as a boolean instead of a function
| console.log('Signin success:', result); | ||
|
|
||
| if (isRemember) { | ||
| localStorage.setItem("rememberLogin", "true"); |
There was a problem hiding this comment.
unnecessary to store rememberLogin, can directly get savedEmail and savedPassword if they are stored, if not set to remember, just clear the savedEmail and savedPassword from localstorage
Comment on lines
+13
to
+15
| theme === 'dark' | ||
| ? root.classList.add('dark') | ||
| : root.classList.remove('dark'); |
Overall is excellent work, responsive and toggle theme works perfect. there is a little issue that the background image does not fully display in mobile screen
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.