Open
Conversation
Gary-Distinctioncoding
left a comment
Gary-Distinctioncoding
left a comment
There was a problem hiding this comment.
Overall is good, try to make the naming of the class consistent, left-session and right-card
| <p class="subtitle">Enter details to create your account</p> | ||
|
|
||
| <form> | ||
| <label>Your Name</label> |
There was a problem hiding this comment.
miss for attribute to point to input field
| height: 100vh; | ||
| background-image: url("20251114160805_20251115030208.png"); | ||
| background-size: cover; | ||
| overflow: hidden; |
There was a problem hiding this comment.
this will cause page cannot scroll down if content is exceed the body
| <form> | ||
| <label>Your Name</label> | ||
| <input type="text" placeholder="Enter your name"> | ||
| <br> |
There was a problem hiding this comment.
use
to control the gap is not a good practice, should use margin
Comment on lines
+27
to
+34
| .left-session{ | ||
| flex-basis: 50%; | ||
| background-position: center; | ||
| display: flex; | ||
| flex-direction: column; | ||
| justify-content: center; | ||
| padding: 80px 60px; | ||
| } |
There was a problem hiding this comment.
the content in left session is not horizontal centered, and background-position is unncessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.