Skip to content

Comments

Introduce Publisher and Resolver plugins#45

Open
iRevive wants to merge 3 commits intodjspiewak:masterfrom
iRevive:separate-publisher-resolver
Open

Introduce Publisher and Resolver plugins#45
iRevive wants to merge 3 commits intodjspiewak:masterfrom
iRevive:separate-publisher-resolver

Conversation

@iRevive
Copy link

@iRevive iRevive commented Dec 15, 2021

My attempt to solve #44.

Perhaps githubRepositories should be renamed to githubResolveRepositories to make the self-description clearer?

The update should not be breaking for current users.

githubPublishToRepository and githubRepositories created from githubOwner, githubRepostiory, and githubTokenSource.

githubOwner, githubRepostiory, and githubTokenSource have deprecation warnings.

Publisher example

addSbtPlugin("com.codecommit" % "sbt-github-packages-publisher" % x)

import sbtghpackages.{GitHubRepository, TokenSource}
githubPublishToRepository := GitHubRepository("owner", "repo", TokenSource.Environment("GH_TOKEN"))

Even if a token is missing, only the publish step will fail.

Resolver example

addSbtPlugin("com.codecommit" % "sbt-github-packages-resolver" % x)

import sbtghpackages.{GitHubRepository, TokenSource}
githubRepositories += GitHubRepository("owner", "repo", TokenSource.Environment("GH_TOKEN"))

@iRevive
Copy link
Author

iRevive commented Dec 15, 2021

If this concept is viable, I will improve docs further.

@iRevive iRevive changed the title Introduce Publisher and Resolver plugins. Introduce Publisher and Resolver plugins Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant