Add dlang/tools to the tested projects#130
Merged
MartinNowak merged 2 commits intodlang:masterfrom Jan 28, 2018
Merged
Conversation
Collaborator
|
Thanks for your pull request, @wilzbach! |
wilzbach
commented
Jan 24, 2018
vars/runPipeline.groovy
Outdated
| "dlang-community/D-YAML", // 15s | ||
| "dlang-community/libdparse", // 13s | ||
| "dlang-community/dfmt", // 11s | ||
| "dlang/tools", // not known yet |
Contributor
Author
There was a problem hiding this comment.
It takes quite a while at the moment - 2m44s:
However, this is due to using digger which builds dmd, druntime and phobos from scratch. Once this PR is merged, we don't need to do this as the tools's testsuite will be run on every PR to dmd, druntime and tools. So we can remove the entire digger setup at tools and then update the time. I suspect it's somewhere between 30-60s.
Member
|
Seems blocked until we have a tagged version of dlang/tools that no longer uses Digger in it's test. |
MartinNowak
added a commit
that referenced
this pull request
Jan 28, 2018
Add dlang/tools to the tested projects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just realized we don't run the testsuite of
dlang/tools.