Skip to content

Bump dependencies#194

Merged
s-ludwig merged 4 commits intodlang:masterfrom
wilzbach:bump
Jan 25, 2018
Merged

Bump dependencies#194
s-ludwig merged 4 commits intodlang:masterfrom
wilzbach:bump

Conversation

@wilzbach
Copy link
Contributor

Required for dlang/dmd#7241

"stdx-allocator": "2.77.0",
"taggedalgebraic": "0.10.9",
"vibe-core": "1.4.0-alpha.1",
"vibe-d": "0.8.3-alpha.1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.8.3-alpha.2 fails with:

../../../../vibe/vibe.d-repo/stream/vibe/stream/base64.d(10,8): Error: module stream is in file 'vibe/core/stream.d' which cannot be read
import path[0] = ../../../../vibe/vibe.d-repo/stream
import path[1] = /usr/include/dl

I guess that's an error due to targetType "none" in core/dub.sdl?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, not sure about that, I'll test locally. The same error still happens for vibe-d/vibe.d#2033 on DMD 2.072.x because the latest DUB isn't used anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error was a regression in master (which is used on Project-Tester), and Martin already submitted a fix: dlang/dub#1350

So I will check whether this is still needed.

DMD 2.072.x because the latest DUB isn't used anymore.

Yeah we should allow opt-in upgrade to the latest DUB version in the installer script.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the bump is required for another PR too - https://ci.dlang.io/blue/organizations/jenkins/dlang-org%2Fphobos/detail/PR-5921/24/pipeline

diet-ng 1.4.3: building configuration "library"...
vibe-d:utils 0.8.2: building configuration "library"...
../../../../../.dub/packages/vibe-d-0.8.2/vibe-d/utils/vibe/internal/memory_legacy.d(187,37): Error: constructor `vibe.utils.hashmap.HashMap!(void*, ulong, DefaultHashMapTraits!(void*)).HashMap.this(IAllocator allocator)` is not callable using argument types `(RCIAllocator)`
../../../../../.dub/packages/vibe-d-0.8.2/vibe-d/utils/vibe/internal/utilallocator.d(14,85): Error: cannot implicitly convert expression `(*function () => allocatorObject(instance))()` of type `RCIAllocator` to `std.experimental.allocator.IAllocator`
dmd failed with exit code 1.
[ERROR] /var/lib/jenkins/dlang_projects@2/dlang/dub/test/ddox.sh:11 command failed
[ERROR] /var/lib/jenkins/dlang_projects@2/dlang/dub/test/ddox.sh:11 command failed

dlang/phobos#5921

@@ -1,12 +1,9 @@
language: d
services:
- docker
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that Travis is still green without this -> Docker is enabled by default.

language: d
services:
- docker
d: dmd-2.078.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid requiring such unrelated changes as below in the future.

@s-ludwig s-ludwig merged commit 0059d2e into dlang:master Jan 25, 2018
@wilzbach wilzbach deleted the bump branch January 28, 2018 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants